Are flat or oval laces best for golf shoes?

Both work well. Oval laces are the traditional choice and suit classic leather golf shoes. Flat laces are increasingly popular because they stay tied well and offer more personality - my personal preference.

Golf already has enough traditions. Your laces don't need to be one of them.